Optimize Readme #63
Merged
Optimize Readme #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: - Following [pip official document](https://pip.pypa.io/en/stable/topics/vcs-support/), `git+git` is not recommended. - Current command will make pip call `git clone git://github.com/lilohuang/PyTurboJPEG.git`, which will result in a timeout on some systems (i.e. ubuntu 22.04 + git 2.25.1). The correct command should be `git clone git@github.com:lilohuang/PyTurboJPEG.git`.
|
Will merge it within 3 days. Thanks. |
Merged
lilohuang
added a commit
that referenced
this pull request
Jul 10, 2022
* Optimize Readme (#63) Reason: - Following [pip official document](https://pip.pypa.io/en/stable/topics/vcs-support/), `git+git` is not recommended. - Current command will make pip call `git clone git://github.com/lilohuang/PyTurboJPEG.git`, which will result in a timeout on some systems (i.e. ubuntu 22.04 + git 2.25.1). The correct command should be `git clone git@github.com:lilohuang/PyTurboJPEG.git`. * Update setup.py * Update turbojpeg.py Co-authored-by: LengYue <lengyue@lengyue.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
git+gitis not recommended.git clone git://github.com/lilohuang/PyTurboJPEG.git, which will result in a timeout error on some systems (i.e. ubuntu 22.04 + git 2.25.1). The correct command should begit clone git@github.com:lilohuang/PyTurboJPEG.git.