[Console] Renamed resolve command's -s option to -m (-s conflicts with core Symfony 2.x cmd option), machine readable added to remove command, and both commands output aligned #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfrawley
added
Attn: BC Break
|
Build failure unrelated to PR and caused by symfony/symfony#24105 (which introduced a bad directory check in the |
robfrawley
force-pushed
the
feature-bugfix-console-commands
branch
4 times, most recently
from
52c9c61 to
4b37f14
Compare
- change --as-script/-s option name/shortcut to --machine-readable/-m to fix collision with core symfony 2.x console options (the long name was changed to provide additional clarity) - change option shortcut and name for "as-script/s" to "machine-readable/m" to fix collision with symfony-provided "shell/s" option from the 2.x series - align output formatting and internal implementation of remove command with the improvements already introduced to the resolve command in 1.9.0 - update help content for both remove and resolve commands to align with updated output formatting and better describe all available functionality of the commands - extracted common functionality between resolve and remove commands to a new shared abstract class to remove code duplication - updated CHANGELOG.md and UPGRADE.md to note BC break and detail additional changes - renamed test filter sets to more realistic names and added some additional ones too - completely rewrote remove command tests and refactored resolve command tests to enable shared fixtures and methods between the two - in test app, moved default web loader to descrete, new "web" named loader and made the "default" loader a chain loader that uses "web" as welll as many of the other ones
robfrawley
force-pushed
the
feature-bugfix-console-commands
branch
from
4b37f14 to
6b166b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #988 by renamed the resolve command's
--as-script/-soption to--machine-readable/-m(shortcut-sconflicts with the Symfony 2.x core--shell/-scommand option, and the long name--as-scriptwas unclear as to its meaning), added the--machine-readable/-moption to remove command, and aligned the output of both resolve and remove commands.The resolve command output had already been updated, but the remove command had not been; this has been remedied here. With both commands updated, shared functionality was refactored out into
AbstractCacheCommandand tests were updated and expanded (which will hopefully ensure issues like #988 don't crop up again).The most important user-facing changes are the rewrites of:
AbstractCacheCommand.phpRemoveCacheCommand.phpResolveCacheCommand.phpThe BC break only exists since
1.9.0, when--as-scriptwas added, meaning only for those who updated to1.9.0in the last day and only for those running Symfony2.3or `2.7.