Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependency Injection] Fix compiler pass log message typo #947

Merged
merged 1 commit into from
Jun 20, 2017
Merged

[Dependency Injection] Fix compiler pass log message typo #947

merged 1 commit into from
Jun 20, 2017

Conversation

you-ser
Copy link
Contributor

@you-ser you-ser commented Jun 8, 2017 •
edited
Loading

Q A
Branch? 1.0 or 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets
License MIT
Doc PR

robfrawley
robfrawley approved these changes Jun 8, 2017
View reviewed changes
Copy link
Collaborator

@robfrawley robfrawley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; LGTM.

@robfrawley robfrawley added Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. State: Reviewing This item is being reviewed to determine if it should be accepted. labels Jun 8, 2017
@robfrawley robfrawley added this to the 1.8.1 milestone Jun 8, 2017
@cedricziel
Copy link
Collaborator

Good catch, thank you!

@cedricziel cedricziel merged commit 5c9c7e8 into liip:1.0 Jun 20, 2017
@robfrawley robfrawley changed the title Typo at log message [Dependency Injection] Fix compiler pass log message typo Jul 13, 2017
@robfrawley robfrawley mentioned this pull request Aug 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricziel cedricziel cedricziel approved these changes

@robfrawley robfrawley robfrawley approved these changes

Assignees
No one assigned
Labels
Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. State: Reviewing This item is being reviewed to determine if it should be accepted.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@you-ser @cedricziel @robfrawley