Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Assert expected deprecation using symfony/phpunit-bridge #886

Merged
merged 1 commit into from
Mar 1, 2017
Merged

[Tests] Assert expected deprecation using symfony/phpunit-bridge #886

merged 1 commit into from
Mar 1, 2017

Conversation

robfrawley
Copy link
Collaborator

Q A
Branch? 1.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Use Symfony's phpunit-bridge to properly test deprecation messages.

@robfrawley robfrawley added the Level: Enhancement ✨ This item involves an enhancement to existing functionality. label Mar 1, 2017
@robfrawley robfrawley added this to the 1.7.3 milestone Mar 1, 2017
@robfrawley robfrawley self-assigned this Mar 1, 2017
@robfrawley robfrawley requested a review from alexwilson March 1, 2017 02:34
@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Mar 1, 2017
@robfrawley robfrawley force-pushed the feature-test-deprecations-using-phpunit-bridge branch 3 times, most recently from 2788ec7 to ac00f8f Compare March 1, 2017 03:07
@robfrawley robfrawley changed the title test deprecation messages using phpunit-bridge runtime [CI] Assert expected deprecation using symfony/phpunit-bridge Mar 1, 2017
@robfrawley robfrawley changed the title [CI] Assert expected deprecation using symfony/phpunit-bridge [Tests] Assert expected deprecation using symfony/phpunit-bridge Mar 1, 2017
@robfrawley robfrawley force-pushed the feature-test-deprecations-using-phpunit-bridge branch 2 times, most recently from 0828821 to c1f0c28 Compare March 1, 2017 06:49
@robfrawley robfrawley modified the milestones: 1.7.4, 1.7.3 Mar 1, 2017
@robfrawley robfrawley force-pushed the feature-test-deprecations-using-phpunit-bridge branch 2 times, most recently from 13cb09a to 3dbdf08 Compare March 1, 2017 08:18
@robfrawley robfrawley force-pushed the feature-test-deprecations-using-phpunit-bridge branch from 3dbdf08 to 2c0000f Compare March 1, 2017 08:30
@robfrawley robfrawley modified the milestones: 1.7.3, 1.7.4 Mar 1, 2017
@robfrawley robfrawley merged commit 03e550d into liip:1.0 Mar 1, 2017
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Mar 1, 2017
@robfrawley robfrawley mentioned this pull request Mar 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwilson alexwilson alexwilson approved these changes

Assignees

@robfrawley robfrawley

Labels
Level: Enhancement ✨ This item involves an enhancement to existing functionality.
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@robfrawley @alexwilson @lsmith77