Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options for jpegoptim post-processor #756

Merged
merged 1 commit into from
Jul 22, 2016

Conversation

dylanschoenmakers
Copy link
Contributor

Added configuration options (max, progressive) for the jpegoptim post-processor:

filter_sets:
        my_filter:
            post_processors:
                jpegoptim: { max: 65, progressive: false }

@lsmith77
Copy link
Contributor

can you add a note to the docs and rebase on master?

@lsmith77
Copy link
Contributor

BTW this PR seems to overlap with #720

@alexwilson
Copy link
Collaborator

Might make sense to delay this until after #720 is merged, then it can be rebased and the constructor conflicts can be resolved

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jul 15, 2016
@dylanschoenmakers
Copy link
Contributor Author

Any chance this could be merged now with my latest changes? I've copied the constructor arguments from #720 to match.

@lsmith77
Copy link
Contributor

so you think this PR now makes #720 obsolete?

@alexwilson
Copy link
Collaborator

alexwilson commented Jul 22, 2016

I feel like the two are halves reaching towards the same goal, but with slightly different features and ultimately we should be okay to merge either in first.

If this is merged in first, then I'm happy to rebase #759 (a cleaned up version of #720) again against this today and resolve the constructor conflicts, which will then allow for that to be closed too.

@lsmith77 lsmith77 merged commit 72a78bf into liip:master Jul 22, 2016
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jul 22, 2016
@lsmith77
Copy link
Contributor

ok .. lets go!

@alexwilson
Copy link
Collaborator

wooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants