Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add return types in form #1518

Merged
merged 1 commit into from
Jun 22, 2023
Merged

add return types in form #1518

merged 1 commit into from
Jun 22, 2023

Conversation

garak
Copy link
Contributor

@garak garak commented Jun 19, 2023

Q A
Branch? 2.x
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #1517
License MIT
Doc not needed

Add missing return types, solving deprecations explained in the aforementioned ticket

@coveralls
Copy link

Coverage Status

coverage: 79.868%. remained the same when pulling 6ce9b06 on garak:fix-deprecated into 58b067f on liip:2.x.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@dbu dbu merged commit bbb5d96 into liip:2.x Jun 22, 2023
@dbu dbu mentioned this pull request Jun 22, 2023
@garak garak deleted the fix-deprecated branch July 3, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants