-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Events documentation with signed url example on POST resolve #1511
Conversation
Add Events documentation example with signed url for private resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, good example of how the event system can be used 👍
|
||
|
||
LiipImagineBundle | ||
================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happened here? is it line endings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's like the original file, don't know why my commit pushed as a new file. The line 45 is the only one i added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, nice example!
i fixed the line endings to be linux endings like the rest of the documentation, and applied the fix for my last comment and merged this in 5bf7e87
@@ -307,8 +306,10 @@ You can also use the constructor of the resolver to directly inject multiple opt | |||
- { CacheControl: "max-age=86400" } | |||
tags: | |||
- { name: "liip_imagine.cache.resolver", resolver: "aws_s3_resolver" } | |||
|
|||
You can find an example with private ACL and signed url on the `events`_ section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal links should not be with absolute url, but with the :doc:
syntax, here
:doc:`events chapter <../events.rst>`
Because when the image filtered, it putted as a public resource. I needed to update my acl config and create a listener to solve it.
I just wanted to share my solution because it was not easy to find in the original documentation.