-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flysystem v2 support #1357
Flysystem v2 support #1357
Conversation
@lsmith77 I updated this PR. I fixed some mismatches in the tests from the previous PR and put back the check on |
thx .. also thx for removing phpcs dependency. you re-added support for pre 4.3 versions because you need this yourself? |
No, I tried to maintain BC by keeping the same logic as the loader for v1. But now looking at composer.json, it makes sense to remove it since symfony/mime is mandatory even for symfony v3. I pushed an update. Thank you. |
Is it possible to not introduce a |
@fbourigault well that's case now. Since the loader and resolver must have an unique service id, I'm handling that in But the configuration value remained the same |
awesome thx. |
Thank you as well. |
ah damn .. hit merge and then I remembered that we have failed to update the UPGRADING.md since a while but would like to get back to doing this .. could you add a new section with config instructions for users upgrading to flysystem2? |
@lsmith77 Well, there are no configuration changes. One can simply run Should I make a new PR with this information? |
yes please |
Done in #1359 |
Adding support for Flysystem v2 as drop-in replacement in
FlysystemLoaderFactory
andFlysystemResolverFactory
.