Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use cs2pr to report PHP-CS-Fixer suggestions #1355

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Don't use cs2pr to report PHP-CS-Fixer suggestions #1355

merged 1 commit into from
Feb 10, 2021

Conversation

fbourigault
Copy link
Contributor

Q A
Branch? 2.x
Bug fix? yes
New feature? no
BC breaks? yes/no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

PHP-CS-Fixer doesn't support line numbers in checkstyle output format.

Developer would have to read action output to know what's wrong with PHP-CS-Fixer.

PHP-CS-Fixer doesn't support line numbers in checkstyle output format.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.661% when pulling 42f8994 on fbourigault:github-actions-php-cs-fixer into a04aa40 on liip:2.x.

@lsmith77 lsmith77 merged commit 1cb215c into liip:2.x Feb 10, 2021
@fbourigault fbourigault deleted the github-actions-php-cs-fixer branch February 10, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants