Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest symfony/templating instead of requiring deprecated component #1350

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

ossinkine
Copy link
Contributor

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Since Symfony Templating component is deprecated and proposed to use Twig insead, so I think the right place for symfony/templating in composer.json is suggest section but not require section.

@coveralls
Copy link

coveralls commented Jan 15, 2021

Coverage Status

Coverage remained the same at 83.653% when pulling b14a449 on ossinkine:suggest-templating into 469b178 on liip:2.x.

@lsmith77 lsmith77 merged commit a04aa40 into liip:2.x Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants