Add note for using 302 redirect in HTTP connections for WebP #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
egils
reviewed
Jan 4, 2021
| @@ -264,4 +264,20 @@ If browser supports WebP, the request ``https://localhost/media/cache/resolve/th | |||
| will be redirected to ``https://localhost/media/cache/thumbnail_web_path/images/cats.jpeg.webp`` | |||
| otherwise to ``https://localhost/media/cache/thumbnail_web_path/images/cats.jpeg`` | |||
|
|
|||
| .. note:: | |||
|
|
|||
| Using an unsecured connection (HTTPS) on your site can cause problems with | |||
There was a problem hiding this comment.
unsecured connection (HTTPS) this does not seem to be right. Unsecured is not HTTPS
There was a problem hiding this comment.
Yes. Exactly. It seemed to me that writing unsecured connection (HTTP) would not be clear enough. Therefore, i'm talking about HTTPS, hinting at the security of the connection. Perhaps it would be better to write unsecured connection (non HTTPS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details see this discussion: #1319 (comment)