Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test WebP configuration #1326

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Test WebP configuration #1326

merged 2 commits into from
Dec 30, 2020

Conversation

peter-gribanov
Copy link
Contributor

@peter-gribanov peter-gribanov commented Dec 29, 2020 •
edited
Loading

Q A
Branch? 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1322
License MIT
Doc PR

I added tests to reproduce this problem.
Not check imagewebp() function support because this bundle also supports imagick and gmagick.

@peter-gribanov peter-gribanov changed the title Test webp configuration Test WebP configuration Dec 29, 2020
@coveralls
Copy link

coveralls commented Dec 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 81.394% when pulling 6319329 on peter-gribanov:test_webp_config into c06594a on liip:master.

@peter-gribanov peter-gribanov mentioned this pull request Dec 29, 2020
Closed
@lsmith77 lsmith77 merged commit 202b56e into liip:master Dec 30, 2020
@lsmith77
Copy link
Contributor

so with this merged we can close #1323 ?

@peter-gribanov
Copy link
Contributor Author

@lsmith77 yes. #1323 is not relevant any more.

@lsmith77 lsmith77 mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbourigault fbourigault fbourigault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peter-gribanov @coveralls @lsmith77 @fbourigault