Support PHP 8

[nicwortel]

Q	A
Branch?	2.0
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#1309
License	MIT
Doc PR	not needed

Alternative to #1313. This PR adds the 8.0 builds to GitHub Actions instead of Travis CI.
Feel free to close this PR in favor of #1313 and/or use my work in that PR.

Happy holidays! 🎄

[coveralls]

Coverage decreased (-0.04%) to 81.371% when pulling 6f85d96 on nicwortel:php8 into c06594a on liip:master.

[nicwortel]

As noted in the commit message:

Older versions of imagine/imagine had incompatibilities with PHP 8, even though their composer.json stated it supported PHP 8.

See php-imagine/Imagine@e68b92b.

[nicwortel]

I decided to catch the error instead of changing the tests, to keep the contract consistent across PHP versions.

[nicwortel]

The tests are passing on CI.

On my local machine I'm getting a number of Symfony\Component\DependencyInjection\Exception\ServiceNotFoundExceptions in the ImagineControllerTest, which appear to be caused by a private service liip_imagine.service.filter being fetched from the container in a conditional branch of the test which only runs when the function imagewebp exists.

I can see that imagewebp is being disabled on GitHub Actions and I'm assuming it's also not available on Travis CI? This leads me to believe that this branch of the test doesn't really work and hasn't been tested for a while.

I decided not to touch this in this PR because using self::$container instead of self::$kernel->getContainer() in the test will probably break the Symfony 3.4 job and it's out of scope for this PR. Besides, there seem to be some additional problems as well so I rather not go down the rabbit hole right now. If you want me to, I can see if I can fix this in a separate PR.

[lsmith77]

this PR overlaps with #1313

also note the discussion here https://github.com/liip/LiipImagineBundle/pull/1313/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485R39

/cc @fbourigault

[nicwortel]

@lsmith77

this PR overlaps with #1313

That's correct! I noticed that the build of #1313 was failing and I wanted to take a shot to fix it, as I needed LiipImagineBundle in a new PHP 8 project (I'm currently using my fork as a Composer dependency).
Also, after the creation of #1313 this repository was migrated from Travis CI to GitHub Actions, so this PR adds the build to GH Actions instead of Travis CI.

It isn't my intention to steal @garak's thunder so feel free to close this PR in favor of #1313 and/or reuse my work there 🙂

also note the discussion here https://github.com/liip/LiipImagineBundle/pull/1313/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485R39

Yes, I ran into the same issue working on this PR. I fixed it by raising the required imagine/imagine version to ^1.2.4 which fixes a PHP 8 incompatibility (also see this comment), to prevent people running an incompatible version on PHP 8. Let me know if you'd prefer me to roll that back and instead run the --prefer-lowest job on an older PHP version (such as 7.4).

[lsmith77]

ok. sounds good.

will wait for @fbourigault to give a nod befire merging

[fbourigault]

Looks good to me!

[garak]

It isn't my intention to steal @garak's thunder so feel free to close this PR in favor of #1313 and/or reuse my work there slightly_smiling_face

Thanks for worrying about it, no problem on my side

[stephanvierkant]

When will a new version be released?

[stephanvierkant]

Ping @lsmith77

[lsmith77]

its coming https://twitter.com/lsmith/status/1359147344818819080?s=20