[Async] [DI] Make resolve_cache_processor a public service #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liip_imagine.async.resolve_cache_processor should be public or an exception is thrown when sending enqueue command.
|
@makasim This involves the async functionality you almost exclusively wrote yourself; is this how you want to handle the situation for Symfony |
|
@makasim ping |
robfrawley
changed the title
robfrawley
changed the title
|
This how it should be, at least for now since we still support SF2,3,4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
liip_imagine.async.resolve_cache_processor should be public or an exception is thrown when sending enqueue command.
I had an exception about this service needing to be public using SF4. All services are private by default now. Not sure where it was used and if dependency injection through the __construct method would be preferred but wanted to submit this PR as a quick easy fix which shouldn't result in any breaking changes with older symfony versions either.