lets just run simple-phpunit

[dbu]

Q	A
Branch?	2.0
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	=> travis
Fixed tickets	-
License	MIT
Doc PR	-

Trying to fix setup of travis testing.

[sebastianblum]

@dbu David, in der composer.json ist das bin-dir mit "bin" anstatt "vendor/bin" angegeben.
Du müsstest die Tests ohne ./vendor/ laufen lassen oder die composer.json anpassen.

[dbu]

in der composer.json ist das bin-dir mit "bin" anstatt "vendor/bin" angegeben.
Du müsstest die Tests ohne ./vendor/ laufen lassen oder die composer.json anpassen.

nur für branch 1.0, dieser merge request ist für 2.0 und da wurde die bin config entfernt. würde das phpunit binary nicht gefunden, müsste auch ein fehler ausgegeben werden.

[dbu]

@lsmith77 would you have an idea why this is not running any tests? locally it worked for me.

[lsmith77]

seem to be passing now .. ?

[cedricziel]

Passing nur IMHO without running any tests. There's no output

[lsmith77]

ah .. strange

[sebastianblum]

@dbu & @lsmith77 the problem is in my opinion, that symfony/phpunit-bridge runs phpunit 5.7 at php 7.1 (there are no tests executed) and phpunit 6.5 at 7.2 (tests are fine)

I'm trying a lot in this pull request #1029 but locally it is running because of phpunit ^6.0 in the composer.json

[dbu]

if we can move everything to phpunit 6 only, thats fine too. we don't need to support different versions of phpunit or anything, the tests are just for this bundle itself. does #1029 replace this PR?

[sebastianblum]

no @dbu #1029 has too much changes and should be deleted.
If I have a solution, you can update this request or I will create a new clean pull request.

[sebastianblum]

@dbu can you please have a look at https://travis-ci.org/liip/LiipImagineBundle/builds/324187910
now #1029 looks much better

[dbu]

that looks indeed a lot better. i would be happy if we just merge #1029, no need to further split that up imho.

[sebastianblum]

@dbu can you squash #1029 ? is squashing commits while merging enabled for this repo?

[dbu]

fixed in #1029