Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings -> Tags Angular Migration #719

Merged
merged 43 commits into from
Dec 18, 2023
Merged

Conversation

mburri
Copy link
Member

@mburri mburri commented Dec 7, 2023

This PR includes:

  • Settings -> Tags in migrated to angular
  • New endpoints to list, create and delete (global) tags
  • the roles/ permissions page was moved to the settings module
  • styles for roles/ permission where adjusted to look like /settings/tags

This PR does not include:

  • Deletion of JSF Pages and Beans for settings/ tags. This will be a separate PR
  • Cleanups in the existing angular code - there is a huge potential to clean up lots of code. Code cleanups will be done with future development

A lot of the changes in the files are caused by new formatting and linting rules. We now use prettier consistently which causes lots of reformattings

llorentelemmc and others added 30 commits November 20, 2023 13:54
setup projcet to support persistence unit tests
@mburri mburri requested a review from yvespp December 7, 2023 20:34
@yvespp yvespp added this to the Version 1.17.33 milestone Dec 15, 2023
@mburri
Copy link
Member Author

mburri commented Dec 18, 2023

@yvespp I've just pushed a change to make the screens a bit wider - they still don't take up 100% of the screen for wide displays.

@yvespp yvespp merged commit 829c06f into master Dec 18, 2023
1 check passed
@yvespp yvespp deleted the feature/716-create-tags-angular branch December 18, 2023 12:45
@llorentelemmc llorentelemmc linked an issue Jan 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace JSF GUI in Settings -> Tags page with Angular
3 participants