Issue/487 copied instance properties #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this on our env and some values are now not copied when:
The same happens for properties that are defined on the relations of the copied resource. |
…t of the copied resource
mburri
force-pushed
the
issue/487-copied-instance-properties
branch
from
a1e7fd4
to
64aa72a
Compare
|
Replaced by #659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 48180f1 fixes the issue: a new property descriptor is created and persisted if the property belongs to the copied resource.
I started to refactor the method afterwards to clean up the code an make the intent more clear. Most refactorings were performed using the extract method/ invert "if" confition refactorings from intellij.
The existing (parametrized) tests already covered almost all affected code - I had to add only one for the case where the value of the origin property is merged into the target property.
fixes #487