Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/522 copy from for all resources #579

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Feature/522 copy from for all resources #579

merged 5 commits into from
Dec 2, 2020

Conversation

mburri
Copy link
Member

@mburri mburri commented Nov 20, 2020

allow copy properties for all resource types, not just applications and application servers.

fixes #522

@mburri mburri requested a review from yvespp November 20, 2020 15:14
@yvespp yvespp added this to the Version 1.17.19 milestone Nov 20, 2020
@yvespp
Copy link
Member

yvespp commented Nov 23, 2020

@mburri there are NullPointers in the tests on travis:

[ERROR] ch.mobi.itc.mobiliar.rest.resources.ResourcesRestTest.shouldReturnBadRequestWhenCopyFromDoesNotSucceed  Time elapsed: 0.029 s  <<< ERROR!
java.lang.NullPointerException
	at ch.mobi.itc.mobiliar.rest.resources.ResourcesRestTest.shouldReturnBadRequestWhenCopyFromDoesNotSucceed(ResourcesRestTest.java:419)
[ERROR] ch.mobi.itc.mobiliar.rest.resources.ResourcesRestTest.shouldNotAllowCopyFromResourceOfDifferentTypes  Time elapsed: 0.002 s  <<< ERROR!
java.lang.NullPointerException
	at ch.mobi.itc.mobiliar.rest.resources.ResourcesRestTest.shouldNotAllowCopyFromResourceOfDifferentTypes(ResourcesRestTest.java:459)
[ERROR] ch.mobi.itc.mobiliar.rest.resources.ResourcesRestTest.shouldAllowCopyFromResourceOfNodeType  Time elapsed: 0.002 s  <<< ERROR!
java.lang.NullPointerException
	at ch.mobi.itc.mobiliar.rest.resources.ResourcesRestTest.shouldAllowCopyFromResourceOfNodeType(ResourcesRestTest.java:499)

Can you please have a look?

@mburri mburri force-pushed the feature/522-copyFrom-for-all-resources branch from 6080c2b to 5c8d92a Compare November 24, 2020 07:29
@yvespp yvespp merged commit 84b0bd2 into master Dec 2, 2020
@yvespp yvespp deleted the feature/522-copyFrom-for-all-resources branch December 2, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvespp yvespp yvespp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.17.19
Development

Successfully merging this pull request may close these issues.

Rest /resources/{resourceGroupName}/{releaseName}/copyFrom for all resource
2 participants
@mburri @yvespp