Bring filters back into url, clear session storage on apply empty filter #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvespp
requested changes
Nov 22, 2017
| @@ -176,7 +174,7 @@ export class DeploymentsListComponent { | |||
| } | |||
|
|
|||
| logViewerLink(deploymentId: number){ | |||
| window.location.href = '/AMW_web/pages/logView.xhtml?deploymentId=' + deploymentId + '&filters=' + encodeURI(JSON.stringify(this.filtersInUrl)) | |||
There was a problem hiding this comment.
I just added this, can't we keep it? See comment here: #247 (comment)
| @@ -665,4 +652,12 @@ export class DeploymentsComponent implements OnInit { | |||
| this.isLoading = false; | |||
| } | |||
|
|
|||
| private goTo(destination: string) { | |||
There was a problem hiding this comment.
goTo is a very generic name, can we call this updateFiltersInURL or something more descriptive?
| @@ -332,7 +332,7 @@ describe('DeploymentsComponent (without query params)', () => { | |||
| expect(deploymentsComponent.filters.length).toEqual(2); | |||
| })); | |||
|
|
|||
| it('should apply filters and add them to the sessionStorage on applyFilter', | |||
| it('should apply filters and add them to the sessionStorage on applyFilterss', | |||
yvespp
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245 & closes #250