Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging collector to otel-cloud-stack chart #37

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

rossmcdonald
Copy link
Contributor

This PR adds a logging collector section to the otel-cloud-stack values, allowing users to collect Kubernetes logs and events and send them to SN Cloud Observability by setting logsCollector.enabled=true.

Note - I opted to create a new set of collectors for logging instead of piggybacking on the daemonCollector, even though they are both daemonsets. Let me know if we should merge the configs into that collector instead to avoid having two separate daemonsets.

@jaronoff97
Copy link
Contributor

hey ross thanks for doing this! I would actually merge the two... we haven't been recommending running both in gateway mode (so you can scale telemetry signal independently) to customers but for a daemonset where you just collect all data on a node, i expect it to be far more uniform.

@rossmcdonald
Copy link
Contributor Author

@jaronoff97 Do you have a preference for how you think the collectors should be merged? Should we just always have logging enabled by default and leave it to the user to remove the relevant section, or should I put it behind a flag of some kind?

The problem I see with putting it behind a flag (at least the way I was thinking of doing it) is that it will require putting the log-specific portion of the config within a template, which will make customizing (for example, adding EKS resource enrichment) much more difficult.

Let me know if you want to sync real quick on the best path forward.

@jaronoff97
Copy link
Contributor

hey ross lets pair on it :) dm me on slack

@jaronoff97
Copy link
Contributor

Hey ross, for now im going to merge this and then we can centralize them all in the future.

@jaronoff97 jaronoff97 merged commit 6eb50d6 into main Sep 28, 2023
1 check passed
@jaronoff97 jaronoff97 deleted the ross/add-logging-to-otel-cloud-stack branch September 28, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants