Update org.stellar.sdk.responses, add missing fields.
#570
Conversation
overcat
force-pushed
the
update-models
branch
from
ab47471 to
a84f757
Compare
| @SerializedName("num_archived_contracts") | ||
| int numArchivedContracts; | ||
|
|
||
| // TODO: remove the above fields when Horizon 3.0 is released. |
There was a problem hiding this comment.
not sure what 3.0 will look like, maybe can remove this, tackle it later when it's known?
There was a problem hiding this comment.
I saw that relevant comment has been added in stellar/go. But we can remove this TODO first, and then remove it here after horizon confirms its removal.
| @SerializedName("core_supported_protocol_version") | ||
| int coreSupportedProtocolVersion; | ||
|
|
||
| @SerializedName("_links") |
There was a problem hiding this comment.
for consideration, Links stands on it's own, could be worth pulling up to it's own class file rather than static under RootResponse.
There was a problem hiding this comment.
Many Response models have their own Links, and I think it's easier to maintain them by putting them together, just like what we did in stellar/go: https://github.com/stellar/go/blob/master/protocols/horizon/main.go#L225-L231
This PR updates
org.stellar.sdk.responsesto add missing fields and adjusts the order of some fields to correspond with the order in stellar/go, making it easier for future maintenance.