Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XDR reference #515

Closed
sreuland opened this issue Aug 22, 2023 · 3 comments
Closed

Update XDR reference #515

sreuland opened this issue Aug 22, 2023 · 3 comments
Assignees

Comments

@sreuland
Copy link
Contributor

What problem does your feature solve?

there is a newer version of xdr available for Protocol 20, soroban:
stellar-xdr:7015193879e9da7cb70d889a49eecf494fefe7e1

for reference, same update to xdr being done on mono repo here:
https://github.com/stellar/go/pull/5023/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

What would you like to see?

the xdr generated classes in java are updated to this version of xdr and any compile time issues that may arise are resolved.

What alternatives are there?

@sreuland
Copy link
Contributor Author

@overcat , might be good to hold on doing this xdr version until we know it's confirmed, there's another adjustment about to land - stellar/stellar-xdr#137

@sreuland
Copy link
Contributor Author

sreuland commented Sep 6, 2023

@overcat , I think it's getting closer to stable for xdr version for next release, this latest xdr version may be the candidate to generate from, the js sdk is sitting on this version for now also:

https://github.com/stellar/stellar-xdr/tree/65afa63b7f52c898143ebbe9541ef91fcf290ade

sreuland added a commit to overcat-deprecation/java-stellar-sdk that referenced this issue Sep 18, 2023
sreuland added a commit to overcat-deprecation/java-stellar-sdk that referenced this issue Sep 18, 2023
@overcat
Copy link
Member

overcat commented Sep 19, 2023

Implemented in #530.

@overcat overcat closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants