watchtower: handle rogue updates #7981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The watchtower client test framework currently uses a mock version of the tower client DB. This can lead to bugs if the mock DB works slightly differently to the actual bbolt DB. So this commit ensures that we only use the bbolt db for the tower client tests. We also increment the `waitTime` used in the tests a bit to account for the slightly longer DB read and write times. Doing this switch resulted in one bug being caught: we were not removing sessions from the in-memory set on deletion of the session and so that is fixed here too.
Remove the use of the mock tower client DB and use the actual bbolt DB everywhere instead.
ellemouton
force-pushed
the
handleRogueUpdates
branch
from
39e0097
to
76ee463
Compare
ellemouton
force-pushed
the
handleRogueUpdates
branch
from
76ee463
to
c0014c2
Compare
ellemouton
force-pushed
the
handleRogueUpdates
branch
from
c0014c2
to
0d93a9b
Compare
yyforyongyu
reviewed
Sep 14, 2023
This commit adds a new test to the tower client to demonstrate a bug that can happen if a channel is closed while an update for it has yet to be acked by the tower server. This will be fixed in an upcomming commit.
A pure refactor commit that passes the required buckets to the `getRangesWriteBucket` instead of re-fetching them.
In this commit, we introduce the concept of a rogue update. An update is rogue if we need to ACK it but we have already deleted all the data for the associated channel due to the channel being closed. In this case, we now no longer error out and instead keep count of how many rogue updates a session has backed-up.
ellemouton
force-pushed
the
handleRogueUpdates
branch
from
0d93a9b
to
95c2bfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we take introduce the concept of a "Rogue Update". A rogue update is an update of a channel that has already been closed. With this PR, if we go to Ack an update and discover that it is rogue, we will just keep count of the number of rogue updates that the session has backed-up.
In the first few commits, the testing infrastructure of the tower client is changed to only use the bbolt implementation instead of a mock implementation of the DB. This is so that the DB code can be tested properly.
Fixes #7980