Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnrpc: adding account name to the WalletBalance rpc #7857

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

hieblmi
Copy link
Collaborator

@hieblmi hieblmi commented Jul 26, 2023

This PR enables the WalletBalance rpc to calculate balances off of a specified account name. Previously only the default account was queried.

Tested on regtest.

@hieblmi hieblmi changed the title Wallet balance account lnrpc: Adding account name to the WalletBalance rpc Jul 26, 2023
@hieblmi hieblmi changed the title lnrpc: Adding account name to the WalletBalance rpc lnrpc: adding account name to the WalletBalance rpc Jul 26, 2023
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and useful feature!
Only nits.

lnrpc/lightning.proto Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
cmd/lncli/commands.go Outdated Show resolved Hide resolved
docs/release-notes/release-notes-0.17.0.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Collaborator

@ProofOfKeags ProofOfKeags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one non-blocking comment to help with user intuition.

lnrpc/lightning.swagger.json Outdated Show resolved Hide resolved
@guggero guggero merged commit d62bed2 into lightningnetwork:master Aug 2, 2023
20 of 24 checks passed
@saubyk saubyk added this to the v0.17.0 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants