-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnrpc: adding account name to the WalletBalance
rpc
#7857
lnrpc: adding account name to the WalletBalance
rpc
#7857
Conversation
WalletBalance
rpc
WalletBalance
rpcWalletBalance
rpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and useful feature!
Only nits.
5daaacf
to
718f24c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one non-blocking comment to help with user intuition.
718f24c
to
6282e0c
Compare
This PR enables the
WalletBalance
rpc to calculate balances off of a specified account name. Previously only the default account was queried.Tested on regtest.