Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel the Rebroadcasting of a Transaction when Abandoning a Channel #7819

Merged

Conversation

ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented Jul 11, 2023

Resulted from discussions in #7746.

Short follow-up PR which makes sure we do not end up confirming a channel although we already abandoned it.

More detailed description here

@ziggie1984 ziggie1984 force-pushed the abandonchannel-rebroadcaster branch from bd82edf to cf1aa1e Compare July 11, 2023 07:22
@ziggie1984 ziggie1984 marked this pull request as ready for review July 11, 2023 07:27
@yyforyongyu yyforyongyu self-requested a review July 11, 2023 10:25
@lightninglabs-deploy
Copy link

@yyforyongyu: review reminder

@yyforyongyu
Copy link
Collaborator

Needs a rebase!

Adding the ability to stop rebroadcasting a transaction. This is
useful when we want to abandon a channel and grantee that this
transaction will not confirm accidentally.
When abandoning a channel we make sure we cancel the rebroadcasting
of the transaction.
Copy link
Collaborator

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🦾

@saubyk saubyk modified the milestone: v0.17.0 Aug 10, 2023
@saubyk saubyk requested a review from guggero August 10, 2023 00:11
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@guggero guggero merged commit d930dce into lightningnetwork:master Aug 10, 2023
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants