brontide: deterministic fuzz targets #7618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
|
@Crypt-iQ: review reminder |
Roasbeef
approved these changes
May 23, 2023
The nilAndPanic function does not actually nil the Curve fields as it claims. dumpAndFail is a more descriptive name.
Move the functionality directly into completeHandshake instead. If a failure does happen at any point during the handshake, it is beneficial to know which line it happens on for debugging. The helper function was hiding this information.
It is best to have deterministic fuzz targets, so that if a failure occurs, it can be easily reproduced. This commit swaps the cryptographically secure RNG for a deterministic one seeded from fuzzer input.
morehouse
force-pushed
the
derandomize_brontide_fuzz
branch
from
1815536
to
354133e
Compare
|
Rebased and added release note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzz targets that are truly random make it difficult to reproduce failures. This PR seeds the private key RNG from fuzzer input so that any crashes found during the initial handshake are reproducible.
Tested with 35 CPU-hours of fuzzing for each
FuzzRandom*target, with no crashes found.