lnd: generate default macaroons independently #7592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaman
force-pushed
the
gen-default-macaroons-independently
branch
2 times, most recently
from
8c3e421
to
589fb8b
Compare
guggero
reviewed
Apr 12, 2023
sangaman
force-pushed
the
gen-default-macaroons-independently
branch
from
589fb8b
to
c3c67a9
Compare
|
Thanks @guggero! I believe I've addressed all your feedback. |
sangaman
force-pushed
the
gen-default-macaroons-independently
branch
from
c3c67a9
to
ab7a3f4
Compare
ellemouton
approved these changes
Apr 17, 2023
|
@sputn1ck: review reminder |
|
@sangaman - this juuuust missed the 0.16.1 cutoff :( can you more the release note to the 0.17.0 doc please? |
This modifies the `genMacaroons` logic to indepently check for each of the three default macaroons (admin, readonly, invoice) and generate whichever are missing. Previously, this was an all or nothing routine. In other words, either all three didn't exist on disk and all three are created, or no macaroons are created. Although that works for the first run of a new node, it can result in inconsistent states if only one or two of the macaroons is deleted. See lightningnetwork#7566.
sangaman
force-pushed
the
gen-default-macaroons-independently
branch
from
ab7a3f4
to
16463d4
Compare
|
I moved the release note from 0.16.1 to 0.17.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This modifies the
genMacaroonslogic to indepently check for each of the three default macaroons (admin, readonly, invoice) and generate whichever are missing. Previously, this was an all or nothing routine. In other words, either all three didn't exist on disk and all three are created, or no macaroons are created. Although that works for the first run of a new node, it can result in inconsistent states if only one or two of the macaroons is deleted.See #7566.
Steps to Test
admin.macaroonare created.admin.macaroon.admin.macaroonhas been recreated.