docker lnd: add support for custom params RPCHOST and RPCCRTPATH #7429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we add support for two more custom parameters in the main entrypoint for the `lnd` Docker image script (`start-lnd.sh`) The two parameters are: * RPCHOST to set a custom endpoint for the RPC server * RPCCRTPATH to set a custom location for the certificate used when communicating with the RPC server
Add link to current release notes for this commit PR
|
Oh ,actually - it is still missing an entry in the release notes @eldios |
|
I was still adding it cause I needed the URL 😝 |
|
Replaced by/included in #7689, original commit author credits are preserved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
In this commit we add support for two more custom parameters in the main entrypoint for the
lndDocker image script (start-lnd.sh)The two parameters are:
communicating with the RPC server
Steps to Test
Change should be 100% backward compatible, but it's as easy as creating a new deployment and set the two new variables via environment variables or leave them empty for default values.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.