aliasmgr+channeldb: stop deleting zero-conf edges from graph if reorg occurs #7292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crypt-iQ
changed the title
Roasbeef
reviewed
Jan 5, 2023
Crypt-iQ
force-pushed
the
disconnectblock_patch
branch
from
0b635f7 to
29166e3
Compare
positiveblue
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
tACK 👍
The lint is complaining about a couple of things + the branch needs to be rebased and add release notes.
The itest have been migrated to the new format but this one can be updated in another PR (maybe we can create an issue with the good first issue tag)
Crypt-iQ
force-pushed
the
disconnectblock_patch
branch
from
29166e3 to
11150fa
Compare
|
@Crypt-iQ, remember to re-request review from reviewers when ready |
|
Needs a rebase and fix for the linter. |
Crypt-iQ
force-pushed
the
disconnectblock_patch
branch
4 times, most recently
from
f9d4bb7 to
dcfff18
Compare
guggero
requested changes
Jan 25, 2023
When a block is disconnected due to a reorg, DisconnectBlockAtHeight is called for the block height. Prior to this patch, it would delete every SCID in the graph with a block height greater than the disconnected height. This meant that a reorg would delete every zero-conf channel edge from the graph. The fix simply iterates up until the StartingAlias and deletes every SCID between the disconnected height and the StartingAlias height.
This itest asserts that zero-conf edges exist even after a reorg. Without the prior commit, this test fails.
Crypt-iQ
force-pushed
the
disconnectblock_patch
branch
from
dcfff18 to
b002879
Compare
guggero
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7229
Description of issue:
When a block is disconnected due to a reorg, DisconnectBlockAtHeight is called for the block height. Prior to this patch, it would delete every SCID in the graph with a block height greater than the disconnected height. This meant that a reorg would delete every zero-conf channel edge from the graph. The fix simply iterates up until the StartingAlias and deletes every SCID between the disconnected height and the StartingAlias height.
An integration test is included that asserts that the fix works.