routing: rename method and add err check when launch shard #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routing/payment_lifecycle.go
Outdated
| @@ -66,10 +66,10 @@ func (ps paymentState) needWaitForShards() bool { | |||
| return ps.terminate || ps.remainingAmt == 0 | |||
| } | |||
|
|
|||
| // updatePaymentState will fetch db for the payment to find the latest | |||
| // fetchePaymentState will query the db for the latest payment state | |||
There was a problem hiding this comment.
Suggested change
| // fetchePaymentState will query the db for the latest payment state | |
| // fetchPaymentState will query the db for the latest payment state |
A followup commit for PR#5332. In this commit we add more docs, rename function updatePaymentState to fetchePaymentState, and add back the check for channeldb.ErrPaymentTerminal after we launch shard.
yyforyongyu
force-pushed
the
5259-follow-up
branch
from
7e47f16
to
4a23c08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up commit for PR #5332 . In this commit we add more docs, rename
function updatePaymentState to fetchePaymentState, and add back the
check for
channeldb.ErrPaymentTerminalafter we launch shard.