peer: avoid chansync resend loop #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested changes
Feb 19, 2020
halseth
force-pushed
the
avoid-resend-chansync-loop
branch
from
a377a5d to
77a2dbf
Compare
Roasbeef
approved these changes
Mar 10, 2020
If a peer receives a channel reestablish message shortly after the channel has been closed, it will resend its own channel reestablish message. In the meantime the other peer could also have seen the channel being closed and will also resend its own message. This leads to a resend loop that never terminates. To avoid two peers getting into this situation, we now allow only one such resent message per conection.
halseth
force-pushed
the
avoid-resend-chansync-loop
branch
from
77a2dbf to
7b8eae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a peer receives a channel reestablish message shortly after the
channel has been closed, it will resend its own channel reestablish
message. In the meantime the other peer could also have seen the channel
being closed and will also resend its own message. This leads to a
resend loop that never terminates.
To avoid two peers getting into this situation, we now allow only one
such resent message per conenction.
Noticed during integration tests: https://travis-ci.org/lightningnetwork/lnd/jobs/650839757?utm_medium=notification&utm_source=github_status