Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numerous typos #101

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

trevinhofmann
Copy link
Contributor

@trevinhofmann trevinhofmann commented Jan 13, 2017

This pull request fixes a large number of typos in the project. These include minor changes in spelling, grammar, or phrasing. Most changes are in documentation, comments, and log messages. The two other changes are highlighted here:

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I really appreciate the fix-ups and the grammatically consistency this PR introduces.

I know I originally suggested that you break up your changes into individual commits, but I think this PR will be more manageable it it were to be squashed down into a single commit. That single commit would have a sub-system prefix of multi: within the header message.

I can either squash the commits here on Github, or you can do it yourself, then force push to the branch. It's up to you.

@trevinhofmann
Copy link
Contributor Author

Squashed!

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📚

@Roasbeef Roasbeef merged commit 40c7bac into lightningnetwork:master Jan 18, 2017
mrfelton pushed a commit to LN-Zap/lnd that referenced this pull request May 10, 2024
…-private-dep

Allow CodeQL to build LND with private dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants