rpc: populate allowed/not allowed node ids when listing orders #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
requested changes
Jan 5, 2023
rpcserver.go
Outdated
| [][]byte, 0, len(dbOrder.Details().AllowedNodeIDs), | ||
| ) | ||
| for _, nodeID := range dbOrder.Details().AllowedNodeIDs { | ||
| allowedNodeIDs = append(allowedNodeIDs, nodeID[:]) |
There was a problem hiding this comment.
I think we need to explicitly copy() these values to avoid issues with the loop variable.
There was a problem hiding this comment.
Right, tests added for it 👍
To have this done everywhere with the same structure we could have a serialize.go in each package that has the logic to serialize/deserialize obj from/to rpc and rpcserver.go calls those. In that way we can keep the testing (with invalid inputs) in the package itself. Similar to the current rpc_parse.go in orders but without splitting the logic between that file and the rpcserver.go.
guggero
approved these changes
Jan 5, 2023
guggero
reviewed
Jan 6, 2023
positiveblue
commented
Jan 6, 2023
| && git config --global --add safe.directory /build | ||
| # The last line is needed to ensure that go build is able to gather | ||
| # information from the vsc used in the builds to get the commit hash. | ||
| && chmod -R 777 /tmp/build/ |
There was a problem hiding this comment.
reverts a commit that I pushed by error in #426
jbrill
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428
Depends on #427