rpcserver: roll back #330

[guggero]

To fix an accidental market segregation for lnd 0.14.x users that didn't
set an explicit channel type in their bid orders, we roll back the
changes from #330.
We can re-enable this default value selection once a large number of ask
orders support the new channel type.

Fixes #349.

[lightninglabs-deploy]

@Roasbeef: review reminder

[Roasbeef]

LGTM ⛩

[Roasbeef]

What if we also made this default commitment type be ChannelTypeScriptEnforced if neither side explicitly specified a type? This way we don't fragment the order book (this rollback), but can optimistically promote the latest channel type (script enforce in this case) from the PoV of the maker (the one opening the channel in the first place).

[guggero]

What if we also made this default commitment type be ChannelTypeScriptEnforced if neither side explicitly specified a type? This way we don't fragment the order book (this rollback), but can optimistically promote the latest channel type (script enforce in this case) from the PoV of the maker (the one opening the channel in the first place).

I think the problem with this is that we don't know if both nodes actually support the script enforced channel type on the lnd level. That's why we added this version based bump in the first place, to signal readiness. Or did I misunderstand what you meant?

[Roasbeef]

I think the problem with this is that we don't know if both nodes actually support the script enforced channel type on the lnd level.

Assuming we can use the order versioning sent as a proxy, then I think that should work?