Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional batch version for itests #331

Merged
merged 5 commits into from
Dec 23, 2021
Merged

Conversation

guggero
Copy link
Member

@guggero guggero commented Dec 21, 2021

Makes the batch version configurable to enable integration testing of different client batch versions in the same batch.

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

@guggero guggero requested a review from positiveblue December 21, 2021 13:41
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will make testing/debugging easier.

order/batch_verifier.go Outdated Show resolved Hide resolved
@guggero guggero force-pushed the conditional-batch-version branch from 63294ea to cd3b6b6 Compare December 22, 2021 08:47
@guggero guggero requested a review from bhandras December 22, 2021 08:48
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

config.go Show resolved Hide resolved
@guggero guggero merged commit 9bc0047 into master Dec 23, 2021
@guggero guggero deleted the conditional-batch-version branch December 23, 2021 08:47
positiveblue added a commit to positiveblue/pool that referenced this pull request Oct 11, 2022
…aper-retry-refactor

Bos score scraper retry refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants