Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AbstractKVStoreIntegrationTest and PostgresImpl Test #6

Closed
wants to merge 10 commits into from
Closed

Add AbstractKVStoreIntegrationTest and PostgresImpl Test #6

wants to merge 10 commits into from

Conversation

G8XSU
Copy link
Collaborator

@G8XSU G8XSU commented Jan 25, 2023 •
edited
Loading

Based on #5

How?

  • PostgresIntegrationTest uses testcontainers to spin up docker containers for each test.
  • AbstractKVStoreIntegrationTest defines behavior that every impl of KVStore needs to follow. Different impl's can re-use the same abstract class to test their impl against it.
  • We will keep on adding tests to this as we add more impl details.

Files to review:

  • AbstractKVStoreIntegrationTest
  • PostgresBackendImplIntegrationTest

@G8XSU G8XSU mentioned this pull request Apr 19, 2023
Merged
@G8XSU G8XSU mentioned this pull request May 10, 2023
Open
31 tasks
@G8XSU
Copy link
Collaborator Author

G8XSU commented Jun 15, 2023

Reviewed and merged as part of another PR

@G8XSU G8XSU closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@G8XSU