Update bindings for new Listen interface #811
Conversation
Codecov Report
@@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 91.06% 91.01% -0.06%
==========================================
Files 48 48
Lines 25495 25495
==========================================
- Hits 23218 23204 -14
- Misses 2277 2291 +14
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2021-02-bindings-rust-bump
branch
from
7c65fbb to
e5f42aa
Compare
Note that this uses rust-bitcoin/rust-secp256k1#279
For ChannelManager, at least, we have two separate functions called block_connected, one in the Listen trait, one in the struct, we need to be explicit with which one we're trying to call.
TheBlueMatt
force-pushed
the
2021-02-bindings-rust-bump
branch
from
e5f42aa to
b37d090
Compare
There was a problem hiding this comment.
New genbindings works for me! LGTM
(build broken, but I think that's related to #812?)
|
Yea, I kicked the build to make it run again without changing the code. |
c-bindings-gen/README.md
Outdated
| This program parses a single-file-lib.rs Rust crate's AST passed in on stdin and generates a second | ||
| crate which is C-callable (and carries appropriate annotations for cbindgen). It is usually invoked | ||
| via the `genbindings.sh` script in the top-level directory, which converts the lightning crate into | ||
| a single file with a call to | ||
| `RUSTC_BOOTSTRAP=1 cargo rustc --profile=check -- -Zunstable-options --pretty=expanded`. |
There was a problem hiding this comment.
Were any changes resulting from #802 (comment) incorporated when splitting into this PR? Looks like it may have been missed, but the diff is no longer available there.
There was a problem hiding this comment.
Heh, I'd responded to it, but only partially.
This will switch to use the clang/C WASM ABI instead of the wasm_bindgen WASM ABI as of rustc 1.51 (or nightly since [1]), allowing us to link C and Rust code in a single wasm binary. [1] rust-lang/rust#79998
TheBlueMatt
force-pushed
the
2021-02-bindings-rust-bump
branch
from
3cf8a8c to
ee9ceb4
Compare
|
Squashed without diff. Gonna merge after tests. |
Some of these commits were in #802, but I pulled them out since we needed further bindings updates. This is still based on #802.