Trivial 3997 followups #4000
Merged
Trivial 3997 followups #4000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've assigned @joostjager as a reviewer! |
valentinewallace
previously approved these changes
Aug 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4000 +/- ##
==========================================
+ Coverage 88.93% 88.95% +0.01%
==========================================
Files 174 174
Lines 124593 124562 -31
Branches 124593 124562 -31
==========================================
- Hits 110813 110803 -10
+ Misses 11283 11263 -20
+ Partials 2497 2496 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The `Keys` struct is only used when building with `ldk_test_vectors` and thus should be gated on it, rather than being marked `#[allow(unused)]`.
This reverts commit 42ea2e9. The commit spuriously concluded that the unused import warnings were due to trait use in macros, but actually they were all used in normal code, not in macros. This appears to simply be a clippy bug where it treats `as _` as indication that an import is unused, even though such imports are useful for importing traits that do not need to be referenced by name.
dunxen
reviewed
Aug 9, 2025
TheBlueMatt
force-pushed
the
2025-08-3997-followups
branch
from
3408966 to
cf04c96
Compare
TheBlueMatt
force-pushed
the
2025-08-3997-followups
branch
from
cf04c96 to
7fba8fc
Compare
dunxen
approved these changes
Aug 10, 2025
|
🔔 1st Reminder Hey @joostjager! This PR has been waiting for your review. |
|
Trivial-enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit may break the linting CI job again, but its a clippy issue we shouldn't be working around it with bogus allows in the code.