Skip to content

[LSPS5] Change notification dooldown time to 1 minute, alsp update docs #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinsaposnic
Copy link
Contributor

@martinsaposnic martinsaposnic commented Aug 7, 2025

LSPS5 follow ups. Addressing comments #3975 (review) and #3975 (comment)

changes:

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 7, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@martinsaposnic martinsaposnic mentioned this pull request Aug 7, 2025
18 tasks
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.91%. Comparing base (6d47f0a) to head (d638113).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3994      +/-   ##
==========================================
+ Coverage   88.74%   88.91%   +0.16%     
==========================================
  Files         173      174       +1     
  Lines      124899   125017     +118     
  Branches   124899   125017     +118     
==========================================
+ Hits       110841   111153     +312     
+ Misses      11631    11358     -273     
- Partials     2427     2506      +79     
Flag Coverage Δ
fuzzing 22.09% <0.00%> (?)
tests 88.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase now.

@tnull tnull removed the request for review from joostjager August 7, 2025 17:30
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from ecf258c to 43eeb48 Compare August 7, 2025 17:37
@martinsaposnic
Copy link
Contributor Author

rebase done!

@martinsaposnic martinsaposnic requested a review from tnull August 7, 2025 17:39
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from 43eeb48 to 24712cf Compare August 7, 2025 17:42
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned elsewhere, we might need a spec change in parallel to this.

Also, nit: 'LSP5', 'dooldown' and 'alsp' typos in the commit message (which could otherwise also use a bit more detail what this change is and why we want it).

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@martinsaposnic martinsaposnic changed the title [LSP5] Change notification dooldown time to 1 minute, alsp update docs [LSP5] Change notification cooldown time to 1 minute, also update docs Aug 11, 2025
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from 24712cf to d638113 Compare August 11, 2025 15:15
@martinsaposnic martinsaposnic changed the title [LSP5] Change notification cooldown time to 1 minute, also update docs [LSPS5] Change notification dooldown time to 1 minute, alsp update docs Aug 11, 2025
@martinsaposnic
Copy link
Contributor Author

martinsaposnic commented Aug 11, 2025

we might need a spec change in parallel to this

lightning/blips#64 spec update PR

@martinsaposnic martinsaposnic requested a review from tnull August 11, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants