-
Notifications
You must be signed in to change notification settings - Fork 418
[LSPS5] Change notification dooldown time to 1 minute, alsp update docs #3994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[LSPS5] Change notification dooldown time to 1 minute, alsp update docs #3994
Conversation
👋 Thanks for assigning @tnull as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3994 +/- ##
==========================================
+ Coverage 88.74% 88.91% +0.16%
==========================================
Files 173 174 +1
Lines 124899 125017 +118
Branches 124899 125017 +118
==========================================
+ Hits 110841 111153 +312
+ Misses 11631 11358 -273
- Partials 2427 2506 +79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a rebase now.
ecf258c
to
43eeb48
Compare
rebase done! |
43eeb48
to
24712cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned elsewhere, we might need a spec change in parallel to this.
Also, nit: 'LSP5', 'dooldown' and 'alsp' typos in the commit message (which could otherwise also use a bit more detail what this change is and why we want it).
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
24712cf
to
d638113
Compare
lightning/blips#64 spec update PR |
LSPS5 follow ups. Addressing comments #3975 (review) and #3975 (comment)
changes: