Pin idna_adapter for older Rust versions in CI #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3626 +/- ##
==========================================
- Coverage 88.60% 88.58% -0.02%
==========================================
Files 151 151
Lines 118454 118454
Branches 118454 118454
==========================================
- Hits 104954 104938 -16
- Misses 10983 10988 +5
- Partials 2517 2528 +11 ☔ View full report in Codecov by Sentry. |
arik-so
changed the title
|
I don't think it's about the MSRVs of these individual downstream dependencies. Rather we should pin |
arik-so
force-pushed
the
tx-sync-pin-litemap
branch
from
e71ec39 to
8487970
Compare
arik-so
changed the title
TheBlueMatt
approved these changes
Feb 27, 2025
|
Merging because this is trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Litemap and zerofrom had recent releases increasing their MSRVs to 1.81.0, which broke tx-sync tests in CI for Rust version 1.75.0.