RawBolt11Invoice to/from ascii utilities #3549
Conversation
lightning-invoice/src/lib.rs
Outdated
| let parsed = UncheckedHrpstring::new(s) | ||
| .map_err(|_| Bolt11ParseError::MalformedHRP)?; | ||
| let hrp = parsed.hrp(); | ||
| let raw_hrp: RawHrp = hrp.to_string().to_lowercase().parse()?; |
There was a problem hiding this comment.
Gah we need to make the HRP decoder support mixed-case strings...allocating a new string just to lower-case it before parsing it is absurd...Doesn't have to happen here, but the over-allocations in this crate irritate me.
lightning-invoice/src/lib.rs
Outdated
|
|
||
| /// Convert from ascii bytes with HRP prefix and base32 encoded data part. | ||
| /// Can be used to receive unsigned invoices for remote signing. | ||
| pub fn from_ascii(s: &str) -> Result<Self, Bolt11ParseError> { |
There was a problem hiding this comment.
I kinda prefer we call this from_bytes or something. The fact that its a string is a bit weird to expose in the API - there's no string serialization for an unsigned invoice, we're just supporting serializing them to bytes for programatic use.
There was a problem hiding this comment.
so there are no low-level utilities to ser/de the data part to bytes, so this would add significant amount of code. I changed this to be [Fe32] for the data part, and str for the hrp. see what you think.
devrandom
force-pushed
the
2025-01-invoice-base32
branch
from
9011867 to
67d736a
Compare
for remote signing of invoices
devrandom
force-pushed
the
2025-01-invoice-base32
branch
from
67d736a to
c16f1c6
Compare
for remote signing of invoices