Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support paying directly to Human Readable Names using bLIP 32 #3283

Merged
merged 8 commits into from
Nov 12, 2024

Set the `dns_resolution` feature in `OMDomainResolver`

cbdb8cb
Select commit
Loading
Failed to load commit list.
Merged

Support paying directly to Human Readable Names using bLIP 32 #3283

Set the `dns_resolution` feature in `OMDomainResolver`
cbdb8cb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 1s

89.67% (+0.02%) compared to b0bd437

View this Pull Request on Codecov

89.67% (+0.02%) compared to b0bd437

Details

Codecov Report

Attention: Patch coverage is 85.27132% with 76 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (b0bd437) to head (cbdb8cb).

Files with missing lines Patch % Lines
lightning-dns-resolver/src/lib.rs 86.77% 34 Missing and 5 partials ⚠️
lightning/src/ln/channelmanager.rs 79.27% 16 Missing and 7 partials ⚠️
lightning/src/ln/outbound_payment.rs 83.60% 9 Missing and 1 partial ⚠️
lightning/src/onion_message/dns_resolution.rs 40.00% 1 Missing and 2 partials ⚠️
lightning/src/offers/refund.rs 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
+ Coverage   89.65%   89.67%   +0.02%     
==========================================
  Files         128      129       +1     
  Lines      104821   105419     +598     
  Branches   104821   105419     +598     
==========================================
+ Hits        93980    94538     +558     
- Misses       8130     8138       +8     
- Partials     2711     2743      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov