Code

[Early Draft] Splicing prototype#3274

Code

Draft

optout21 wants to merge 119 commits intolightningdevkit:mainlightningdevkit/rust-lightning:mainfrom optout21:splicing-hapa9-v123optout21/rust-lightning:splicing-hapa9-v123Copy head branch name to clipboard

+9,322-1,053

Commits

Commits on Oct 11, 2023

• Splicing happy-path proto 3

  optout21

  committed
  de78627

  Copy full SHA for de78627

Commits on Nov 21, 2023

• Splicing happy-path proto 4

  optout21

  committed
  2f6d619

  Copy full SHA for 2f6d619

Commits on Nov 23, 2023

• Move committing to new splice transaction only upon confirmation

  optout21

  committed
  04df7b7

  Copy full SHA for 04df7b7

• Extra check to splice test case (no change before locking)

  optout21

  committed
  03978ed

  Copy full SHA for 03978ed

Commits on Nov 25, 2023

• Reduce redundancy in pre+post+diff storage, check for overflows

  optout21

  committed
  a23d7dd

  Copy full SHA for a23d7dd

Commits on Dec 11, 2023

• Add V2 constructors to ChannelId

  dunxen

  committed
  15176d0

  Copy full SHA for 15176d0

• f use-only Hash trait

  dunxen

  committed
  1b8f177

  Copy full SHA for 1b8f177

• Test builds with #[cfg(dual_funding)] enabled

  dunxen

  committed
  fcd399d

  Copy full SHA for fcd399d

• Add DualFundingChannelContext struct

  dunxen

  committed
  476f6cb

  Copy full SHA for 476f6cb

• Create ChannelContext constructor for inbound channels

  dunxen

  committed
  2e66dc5

  Copy full SHA for 2e66dc5

• Add InboundV2Channel struct

  dunxen

  committed
  2ee04b0

  Copy full SHA for 2ee04b0

• Create ChannelContext constructor for outbound channels

  dunxen

  committed
  2f1fcb7

  Copy full SHA for 2f1fcb7

• Add OutboundV2Channel struct

  dunxen

  committed
  5c68d10

  Copy full SHA for 5c68d10

• Add V2 ChannelPhase variants

  dunxen

  committed
  23febee

  Copy full SHA for 23febee

• Initial InteractiveTxConstructor design

  Show description for 3739aff
  

  3 peoplecommitted
  3739aff

  Copy full SHA for 3739aff

• Add more docs and tests

  

  jurvis

  authored and

  dunxen

  committed
  906e01e

  Copy full SHA for 906e01e

• Add comment on spec clarification

  

  jurvis

  authored and

  dunxen

  committed
  6591432

  Copy full SHA for 6591432

• Add interactive tx constructor to ChannelContext

  dunxen

  committed
  d3659fa

  Copy full SHA for d3659fa

• Add FundingInputsContributionReady event

  dunxen

  committed
  4b9f03a

  Copy full SHA for 4b9f03a

• Implement support for accepting V2 channels

  dunxen

  committed
  29e396c

  Copy full SHA for 29e396c

• Handle initial commitment_signed for V2 channels

  dunxen

  committed
  7689e00

  Copy full SHA for 7689e00

• Handle interactive signing sessions

  dunxen

  committed
  d7b69d9

  Copy full SHA for d7b69d9

• Add option_dual_fund feature

  dunxen

  committed
  0ac3d9a

  Copy full SHA for 0ac3d9a

Commits on Dec 18, 2023

• Splice test: add checks to acceptor node as well

  optout21

  committed
  a146bbe

  Copy full SHA for a146bbe

Commits on Jan 8, 2024

• Minor cleanup

  optout21

  committed
  5db4b3f

  Copy full SHA for 5db4b3f

• Update to main, up to Nov 23 70ea110, bitcoin 0.30.2, splice msgs in

  optout21

  committed
  dfe53d7

  Copy full SHA for dfe53d7

• Update to main, up to Nov 27, 146a291

  optout21

  committed
  d7d2f98

  Copy full SHA for d7d2f98

Commits on Jan 9, 2024

• Update to main, up to Dec 9 0c67753, channel state refactor

  optout21

  committed
  4131866

  Copy full SHA for 4131866

Commits on Jan 10, 2024

• Merge Interactive TX construction branch (dunxen:2023-05-v2channelestablish) into splice proto

  optout21

  committed
  75eff57

  Copy full SHA for 75eff57

• Create test with V2 channel open; test_channel_open_v2_and_close

  optout21

  committed
  e5122bf

  Copy full SHA for e5122bf

Commits on Jan 18, 2024

• Rework Splice proto to use Interactive transaction construction, first shot

  optout21

  committed
  a12876b

  Copy full SHA for a12876b

Commits on Jan 19, 2024

• Clean up non-dual-funding provisionary splice msgs

  optout21

  committed
  704dabb

  Copy full SHA for 704dabb

Commits on Jan 24, 2024

• Signature handling; provide shared signature in tx_signatures, proper built txs

  optout21

  committed
  c0c0832

  Copy full SHA for c0c0832

Commits on Feb 14, 2024

• Splicing proto hapa7; reworked state handling and all

  optout21

  committed
  e812361

  Copy full SHA for e812361

Commits on Feb 16, 2024

• Gossip change for ldk-sample building

  optout21

  committed
  4b7f183

  Copy full SHA for 4b7f183

Commits on Mar 15, 2024

• Adjust resetting the interactive signing session

  optout21

  committed
  9fa7f4f

  Copy full SHA for 9fa7f4f

Commits on Mar 19, 2024

• Massive update, merge recent interactive tx branch (121)

  optout21

  committed
  c604471

  Copy full SHA for c604471

Commits on Apr 2, 2024

• Improve fee estimation, include witness fee

  optout21

  committed
  fc98fd2

  Copy full SHA for fc98fd2

• Adjust the content of SpliceAckedInputsContributionReady::holder_funding_satoshis

  optout21

  committed
  4c54a52

  Copy full SHA for 4c54a52

Commits on Apr 4, 2024

• Fix for tx_signature (duplicate) handling

  optout21

  committed
  6833421

  Copy full SHA for 6833421

Commits on Apr 23, 2024

• Update to version v0.0.122

  optout21

  committed
  c5c9e59

  Copy full SHA for c5c9e59

Commits on Apr 24, 2024

• Add fee check to v2_splice_in test

  optout21

  committed
  4f81562

  Copy full SHA for 4f81562

• Update README

  optout21

  committed
  1aea895

  Copy full SHA for 1aea895

Commits on Apr 25, 2024

• Update to main, at pre 0.0.123 (commit 9a438ee apr24)

  optout21

  committed
  21f8695

  Copy full SHA for 21f8695

Commits on Apr 26, 2024

• Post-merge fixes and improvements from V2 branch

  optout21

  committed
  83d9293

  Copy full SHA for 83d9293

• Fix discrepancy in finding the funding output in sorted/unsorted output list (v2 test failures)

  optout21

  committed
  8c38166

  Copy full SHA for 8c38166

• Remove premature sending of tx_signatures

  optout21

  committed
  95c5aa3

  Copy full SHA for 95c5aa3

• Tests: use realistic-size placeholder signature throughout

  optout21

  committed
  38a5741

  Copy full SHA for 38a5741

Commits on Apr 28, 2024

• Fix tx i&o sorting in IATX ConstructedTransaction, keep them sorted from the start

  optout21

  committed
  55f326e

  Copy full SHA for 55f326e

Commits on Apr 29, 2024

• Adjustment to dual_funding/splicing cfg flags

  optout21

  committed
  885c130

  Copy full SHA for 885c130

Commits on May 2, 2024

• [TestOnly] Add unit tests for testing different order of events on SigningSession

  optout21

  committed
  2011f60

  Copy full SHA for 2011f60

• Factor out common TxSignature decision logic into common fn get_tx_signatures()

  optout21

  committed
  f2ba543

  Copy full SHA for f2ba543

• Factor out handling of funding_transaction_signed() into a method in Channel (no logic change)

  optout21

  committed
  46f51b4

  Copy full SHA for 46f51b4

• Extend provide_holder_witnesses() to also check for fully signed funding tx

  optout21

  committed
  84d9838

  Copy full SHA for 84d9838

• Handle all combinations of event orders, if local sigs come late, etc

  optout21

  committed
  ac45252

  Copy full SHA for ac45252

• Update sequence documentation in Readme

  optout21

  committed
  a957229

  Copy full SHA for a957229

Commits on May 5, 2024

• Fix missing ChannelPending and ChannelReady flags, by clearing corresponding state flags in splice_start()

  optout21

  committed
  974847a

  Copy full SHA for 974847a

Commits on May 6, 2024

• Add interactive tx constructor to ChannelContext

  dunxen

  committed
  6cd57b4

  Copy full SHA for 6cd57b4

Commits on May 7, 2024

• Implement support for accepting V2 channels

  dunxen

  committed
  359bc2f

  Copy full SHA for 359bc2f

• Handle initial commitment_signed for V2 channels

  dunxen

  committed
  4c632af

  Copy full SHA for 4c632af

• Handle interactive signing sessions

  dunxen

  committed
  f9aa520

  Copy full SHA for f9aa520

• Handle re-establishment next_funding_txid

  dunxen

  committed
  e6bcfab

  Copy full SHA for e6bcfab

• Add option_dual_fund feature

  dunxen

  committed
  6b99234

  Copy full SHA for 6b99234

• Extend AwaitingChannelReady state with IS_SPLICE flag

  optout21

  committed
  17ed992

  Copy full SHA for 17ed992

• Make check_get_channel_ready() also check for splice_locked, prepare for sending splice_locked

  optout21

  committed
  46a256c

  Copy full SHA for 46a256c

Commits on May 9, 2024

• Send and handle splice_locked message (similar to channel_ready)

  optout21

  committed
  73bb738

  Copy full SHA for 73bb738

• Call splice_complete() only when splice_locked was both sent and received

  optout21

  committed
  0fe941d

  Copy full SHA for 0fe941d

• Update to main v0.0.123

  optout21

  committed
  536e3b1

  Copy full SHA for 536e3b1

• Update Readme info

  optout21

  committed
  f4f931c

  Copy full SHA for f4f931c

• Add is_splice flag to ChannelPending and ChannelReady events

  optout21

  committed
  7061997

  Copy full SHA for 7061997

Commits on May 10, 2024

• More usage of is_splice_pending(), make it independent of splicing cfg; cleanup

  optout21

  committed
  cb54422

  Copy full SHA for cb54422

Commits on May 17, 2024

• Minor changes in preparation of merging

  optout21

  committed
  d1107da

  Copy full SHA for d1107da

• Minor changes in interactivetx.rs, to bring it closer to dual funding latest

  optout21

  committed
  9e1cb63

  Copy full SHA for 9e1cb63

• For splicing, don’t use contribute_funding_inputs() call, but provide inputs upfront in splice_channel(). This is in preparation for rebase to dual funding latest

  optout21

  committed
  986b66d

  Copy full SHA for 986b66d

• Rebase to latest dual funding branch (2023)

  optout21

  committed
  0212c99

  Copy full SHA for 0212c99

• Minor post-merge cleanup, actual merge

  optout21

  committed
  292f1e0

  Copy full SHA for 292f1e0

• Purge SpliceAckedInputsContributionReady

  optout21

  committed
  f5b53bd

  Copy full SHA for f5b53bd

Commits on May 21, 2024

• Work on test_v2_payment_splice_in_payment() unit test (still fails)

  optout21

  committed
  670a87d

  Copy full SHA for 670a87d

Commits on Jun 3, 2024

• New channel context creation for spliced channel (new_for_splice)

  optout21

  committed
  8ba5012

  Copy full SHA for 8ba5012

• Refine balance updating logic, checks

  optout21

  committed
  b382424

  Copy full SHA for b382424

Commits on Jun 4, 2024

• Calculate interactive funding values correctly from the deltas

  optout21

  committed
  81a02a3

  Copy full SHA for 81a02a3

Commits on Jun 11, 2024

• Minor test touches

  optout21

  committed
  6571da3

  Copy full SHA for 6571da3

Commits on Jun 12, 2024

• During splicing negotiation, don’t advance to next commitment point. Fix payment test

  optout21

  committed
  b47ba51

  Copy full SHA for b47ba51

Commits on Jun 14, 2024

• Compile fix for ‘dual_funding’ cfg

  optout21

  committed
  671c3ba

  Copy full SHA for 671c3ba

• Update splice messages according to new spec draft

  optout21

  committed
  86ff19e

  Copy full SHA for 86ff19e

Commits on Jun 15, 2024

• Update splice messages according to new spec draft

  optout21

  committed
  d2cfcf3

  Copy full SHA for d2cfcf3

• Update splice messages according to new spec draft

  optout21

  committed
  1165377

  Copy full SHA for 1165377

• Refactor splice contribution handling (splice_init and splice_ack contain their contribution respectively)

  optout21

  committed
  138574c

  Copy full SHA for 138574c

Commits on Jun 19, 2024

• Remove channel IDs from Pre/Post info, not needed

  optout21

  committed
  eb6d4d3

  Copy full SHA for eb6d4d3

Commits on Jun 25, 2024

• Add new Renegotiating phase for splicing

  optout21

  committed
  3d3a305

  Copy full SHA for 3d3a305

Commits on Jul 5, 2024

• Rearrange complex test case to test for out-of-order splice_locked scenario

  optout21

  committed
  ce42a96

  Copy full SHA for ce42a96

• Minor refactor: factor out set_channel_ready() method

  optout21

  committed
  feca615

  Copy full SHA for feca615

• Call splice_complete() with set_channel_ready(), handle both splice_locked orders

  optout21

  committed
  26029c4

  Copy full SHA for 26029c4

• Update doc in Readme

  optout21

  committed
  be8ff11

  Copy full SHA for be8ff11

Commits on Aug 16, 2024

• Make ChannelContext::new_for_splice() take reference, clone it; plus some minor.

  optout21

  committed
  9ebe1b6

  Copy full SHA for 9ebe1b6

• RenegotiatingFundingInbound and Outbound: add pre-splice channel to it as well

  optout21

  committed
  90eb001

  Copy full SHA for 90eb001

Commits on Aug 23, 2024

• Use new RenegotiatingFundingPending state (instead of Funded) for funded pending splice

  optout21

  committed
  0a2fb0c

  Copy full SHA for 0a2fb0c

• Make splice tests generic, with payments optional

  optout21

  committed
  05adf97

  Copy full SHA for 05adf97

Commits on Sep 17, 2024

• Remove redeem_script from signing utility, it can derive it

  optout21

  committed
  d8198d2

  Copy full SHA for d8198d2

Commits on Sep 19, 2024

• Minor channel cloning touches

  optout21

  committed
  3fa228b

  Copy full SHA for 3fa228b

Commits on Sep 23, 2024

• Rename (RenegotiatingV2 to RenegotiatingV2

  optout21

  committed
  7628d00

  Copy full SHA for 7628d00

• Add V2Channel, merge RenegotiatingChannel into V2Channel

  optout21

  committed
  522340d

  Copy full SHA for 522340d

• RenegotiatingV2 contains now Channel and ChannelVariants (instead of 2 Channels, step towards RBF)

  optout21

  committed
  02ac3f1

  Copy full SHA for 02ac3f1

Commits on Sep 25, 2024

• Merge RenegotiatingFundingOutbound, -Inbound and RenegotiatingV2 phases into one, with ChannelVariants

  optout21

  committed
  bb7cbd0

  Copy full SHA for bb7cbd0

• Adapt channel cloning, as in 3332

  optout21

  committed
  e781ca3

  Copy full SHA for e781ca3

Commits on Oct 1, 2024

• Rename state to RefundingV2

  optout21

  committed
  2bfd08f

  Copy full SHA for 2bfd08f

Commits on Oct 2, 2024

• Channel context for splicing pending: use post if funded, pre otherwise. Also a rename

  optout21

  committed
  4980a99

  Copy full SHA for 4980a99

• Add test for payment while splice pending (failing)

  optout21

  committed
  6895e92

  Copy full SHA for 6895e92

Commits on Oct 4, 2024

• For DualF, split Funded phase into FundingV2 and Funded

  optout21

  committed
  bbc89f6

  Copy full SHA for bbc89f6

Commits on Oct 5, 2024

• FundingV2 has a ChannelVariants, in prep for RBF

  optout21

  committed
  796912f

  Copy full SHA for 796912f

Commits on Oct 8, 2024

• Add test for dual funding RBF

  optout21

  committed
  25e7579

  Copy full SHA for 25e7579

Commits on Oct 9, 2024

• Implement handling of dual funding RBF

  optout21

  committed
  71accec

  Copy full SHA for 71accec

Commits on Oct 15, 2024

• Minor, in preparation for Splicing+RBF

  optout21

  committed
  b3cc306

  Copy full SHA for b3cc306

• Transition states in separate method (transition_confirmed_channels), in preparation for Splicing+RBF

  optout21

  committed
  c8c091a

  Copy full SHA for c8c091a

• Handle RBF during splice negotiation

  optout21

  committed
  ba0f36e

  Copy full SHA for ba0f36e

Commits on Oct 24, 2024

• Some cleanup in Pre/Post states

  optout21

  committed
  c594f7d

  Copy full SHA for c594f7d

Commits on Nov 18, 2024

• Add checks for funding pubkey (not changing during splicing)

  optout21

  committed
  d9c411f

  Copy full SHA for d9c411f

• Enable splicing on V1 channel as well

  optout21

  committed
  6769fa7

  Copy full SHA for 6769fa7

• Unify V1 and V2 splicing tests

  optout21

  committed
  9b41ae4

  Copy full SHA for 9b41ae4