Update splice messages according to new spec draft #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
==========================================
+ Coverage 89.92% 91.15% +1.22%
==========================================
Files 121 121
Lines 99172 107295 +8123
Branches 99172 107295 +8123
==========================================
+ Hits 89180 97803 +8623
+ Misses 7391 7009 -382
+ Partials 2601 2483 -118 ☔ View full report in Codecov by Sentry. |
optout21
force-pushed
the
splicing-msgs-update
branch
2 times, most recently
from
7423566 to
35a08ae
Compare
TheBlueMatt
previously approved these changes
Jun 17, 2024
optout21
force-pushed
the
splicing-msgs-update
branch
from
35a08ae to
bb84c5f
Compare
|
Pushed some minor fuzz fixes; ready for review. |
jkczyz
reviewed
Jun 21, 2024
optout21
force-pushed
the
splicing-msgs-update
branch
from
bb84c5f to
43a6ee3
Compare
dunxen
approved these changes
Jun 24, 2024
jkczyz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to the splice messages according to new spec draft lightning/bolts#1160
The splicing messages are not yet used (on main).
The list of changes (some new fields, some renames):
CommitmentSigned: New optional batch parameters, used in case multiple commitment are updated at once. Optionalbatchfield of typeCommitmentSignedBatch, containing batch size and funding txid.TxAddInput: New optional fieldshared_input_txid, to be used when during splicing the previous funding transaction is added as an input (funding_txid).TxSignatures: Rename optional field toshared_input_signature, fromfunding_outpoint_sig.SpliceInit: Rename msg to SpliceInit, from Splice (msg is nowsplice_initin spec) (also SendSpliceInit, handle_splice_init)SpliceInit: Rename amount field tofunding_contribution_satoshis(fromrelative_satoshis). Note that his is the part of the initiator only.SpliceInit: New optional bool fieldrequire_confirmed_inputs.SpliceInit: Thechain_hashfield is removed (not needed).SpliceAck: Rename amount field tofunding_contribution_satoshis(fromrelative_satoshis). Note that his is the part of the acceptor only.SpliceAck: New optional bool fieldrequire_confirmed_inputs.SpliceAck: Thechain_hashfield is removed (not needed).SpliceLocked: Added newsplice_txidfield, with the id of the new locked funding txSpliceInitandSpliceAckto80&81(from 75 & 76)