#2128 follow-ups #2801
Merged
#2128 follow-ups #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2801 +/- ##
==========================================
- Coverage 88.46% 88.45% -0.01%
==========================================
Files 114 114
Lines 91806 91810 +4
Branches 91806 91810 +4
==========================================
- Hits 81214 81213 -1
- Misses 8112 8114 +2
- Partials 2480 2483 +3 ☔ View full report in Codecov by Sentry. |
shaavan
approved these changes
Dec 19, 2023
|
Needs rebase, sorry about that. |
|
LGTM after rebase |
The prior name seems to reference onion decode errors specifically, when in fact the error contents are generic failure codes for any error that occurs during HTLC receipt.
There is no outgoing CLTV for received HTLCs, so this new var makes more sense.
.. since there is no outgoing cltv for received HTLCs.
There is no outgoing HTLC for received HTLCs, so rename to be more accurate.
There is no outgoing HTLC for received HTLCs, so rename to be more accurate.
There is no outgoing HTLC for received HTLCs, so rename to be more accurate.
valentinewallace
force-pushed
the
2023-12-rb-groundwork-followups
branch
from
9a0ed7b to
b20a9ad
Compare
|
Rebased. |
dunxen
approved these changes
Jan 10, 2024
60 tasks
|
Gonna land this with 1 ACK since it's trivial renames and at a glance I don't see any majorly conflicting PRs. Happy to rename further in follow-up if there's post-merge review. |
valentinewallace
merged commit 62d52c6
into
lightningdevkit:main
13 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very late follow-up from #2128. Just renames to be more descriptive.