Add is_expired_no_std to Offer
#2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2689 +/- ##
==========================================
- Coverage 88.78% 88.73% -0.05%
==========================================
Files 112 112
Lines 88474 88486 +12
Branches 88474 88486 +12
==========================================
- Hits 78553 78521 -32
- Misses 7686 7726 +40
- Partials 2235 2239 +4
☔ View full report in Codecov by Sentry. |
jkczyz
reviewed
Oct 26, 2023
| @@ -468,6 +468,11 @@ impl Offer { | |||
| self.contents.is_expired() | |||
| } | |||
|
|
|||
| /// Whether the offer has expired given the duration since the Unix epoch. | |||
| pub fn is_expired_no_std(&self, duration_since_epoch: Duration) -> bool { | |||
There was a problem hiding this comment.
Could you add this to Refund? Also, would you mind updating builds_offer_with_absolute_expiry and builds_refund_with_absolute_expiry to call is_expired_no_std as well?
benthecarman
force-pushed
the
no-std-offer-expire
branch
from
9b57128 to
641d7a8
Compare
jkczyz
reviewed
Oct 26, 2023
This was available for OfferContents but not an Offer so dependent projects could not access it.
benthecarman
force-pushed
the
no-std-offer-expire
branch
from
641d7a8 to
5ddd8a7
Compare
jkczyz
approved these changes
Oct 27, 2023
TheBlueMatt
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was available for OfferContents but not an Offer so dependent projects could not access it.