Aggregate `BlindedPayInfo` for blinded routes #2514

valentinewallace · 2023-08-22T22:29:26Z

BOLT 12 invoices encode BlindedPayInfo(s) as part of their hints for routing, whose fields are computed by aggregating fee/cltv/etc values from the hops along the blinded path. Helps address #1970.

~~Based on #2412.~~

codecov-commenter · 2023-08-23T00:41:30Z

Codecov Report

Patch coverage: 88.19% and no project coverage change.

Comparison is base (61d896d) 90.59% compared to head (88a0063) 90.59%.
Report is 41 commits behind head on main.

❗ Current head 88a0063 differs from pull request most recent head 134f6f3. Consider uploading reports for the commit 134f6f3 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #2514    +/-   ##
========================================
  Coverage   90.59%   90.59%            
========================================
  Files         110      110            
  Lines       57410    58062   +652     
  Branches    57410    58062   +652     
========================================
+ Hits        52008    52602   +594     
- Misses       5402     5460    +58

Files Changed	Coverage Δ
lightning/src/blinded_path/mod.rs	`100.00% <ø> (ø)`
lightning/src/blinded_path/payment.rs	`78.90% <85.59%> (+78.90%)`	⬆️
lightning/src/ln/monitor_tests.rs	`98.06% <85.71%> (-0.46%)`	⬇️
lightning/src/chain/chainmonitor.rs	`94.91% <97.22%> (-0.12%)`	⬇️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

lightning/src/blinded_path/payment.rs

lightning/src/blinded_path/mod.rs

lightning/src/blinded_path/payment.rs

valentinewallace · 2023-08-28T17:25:06Z

Rebased to fix CI. I added test coverage for the min htlc computation to #2413 so this should be good for review.

lightning/src/blinded_path/payment.rs

alecchendev

Sorta confused by htlc_minimum_msat, everything else looks good

lightning/src/blinded_path/payment.rs

TheBlueMatt

Okay, sorry for all the noise here, only one comment left I think.

valentinewallace · 2023-09-06T22:29:32Z

I think I addressed all feedback. Thought I saw something about not decrementing htlc_min but I don't see it anymore?

TheBlueMatt · 2023-09-06T22:30:46Z

#2514 (comment) :)

lightning/src/blinded_path/mod.rs

lightning/src/blinded_path/payment.rs

These should've been made public when they were added for use in BlindedPath::new_for_payment.

impl_writeable_tlv_based includes a length prefix to the TLV stream, which we don't want.

valentinewallace added the blocked on dependent pr label Aug 22, 2023

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch from d60f441 to 63025f8 Compare August 22, 2023 22:34

valentinewallace mentioned this pull request Aug 13, 2023

Route blinding MVP #2413

Merged

1 task

valentinewallace added this to the 0.0.117 milestone Aug 23, 2023

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch from 63025f8 to e87c68e Compare August 23, 2023 21:11

valentinewallace removed the blocked on dependent pr label Aug 23, 2023

jkczyz self-requested a review August 23, 2023 21:23

TheBlueMatt reviewed Aug 23, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch 2 times, most recently from b159729 to 35b1dc8 Compare August 24, 2023 15:33

alecchendev reviewed Aug 25, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Show resolved Hide resolved

lightning/src/blinded_path/mod.rs Outdated Show resolved Hide resolved

valentinewallace commented Aug 25, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch 3 times, most recently from c6df2b6 to 4b9f000 Compare August 28, 2023 17:17

Fix BlindedPath::new_for_payment docs

9111138

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch from 4b9f000 to 3ec7789 Compare August 28, 2023 17:23

TheBlueMatt reviewed Aug 28, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

jkczyz reviewed Aug 28, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Show resolved Hide resolved

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch 5 times, most recently from f272645 to 5d0a982 Compare August 30, 2023 15:38

alecchendev reviewed Aug 31, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

TheBlueMatt reviewed Sep 1, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

valentinewallace mentioned this pull request Aug 30, 2023

Route blinding: support forwarding as the intro node #2540

Merged

TheBlueMatt reviewed Sep 4, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch from 5d0a982 to 4777c29 Compare September 6, 2023 18:14

valentinewallace commented Sep 6, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Show resolved Hide resolved

TheBlueMatt reviewed Sep 6, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

lightning/src/blinded_path/payment.rs Show resolved Hide resolved

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

TheBlueMatt reviewed Sep 6, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Show resolved Hide resolved

TheBlueMatt reviewed Sep 6, 2023

View reviewed changes

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch from 4777c29 to a6f881b Compare September 6, 2023 22:17

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch from a6f881b to 88a0063 Compare September 7, 2023 17:33

valentinewallace commented Sep 7, 2023

View reviewed changes

lightning/src/blinded_path/mod.rs Outdated Show resolved Hide resolved

TheBlueMatt previously approved these changes Sep 8, 2023

View reviewed changes

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

lightning/src/blinded_path/payment.rs Outdated Show resolved Hide resolved

valentinewallace dismissed TheBlueMatt’s stale review via 61658ae September 8, 2023 14:35

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch 2 times, most recently from 61658ae to a1b3fbb Compare September 8, 2023 14:37

valentinewallace added 8 commits September 8, 2023 10:43

Compute aggregated BlindedPayInfo in path construction

ec01d7e

Support aggregating htlc_minimum_msat for BlindedPayInfo

02990ca

Support aggregating htlc_maximum_msat for BlindedPayInfo

fc0d151

Make blinded payment TLV fields public.

aee7bb4

These should've been made public when they were added for use in BlindedPath::new_for_payment.

Derive Clone and Debug for blinded payment TLV structs

10a159f

Fix blinded payment TLV ser to not length-prefix

d5925f2

impl_writeable_tlv_based includes a length prefix to the TLV stream, which we don't want.

Remove unnecessary doc links

138a5a7

Struct-ify blinded payment path intermediate node info

f3616e6

valentinewallace force-pushed the 2023-08-compute-blindedpayinfo branch from a1b3fbb to f3616e6 Compare September 8, 2023 14:43

TheBlueMatt approved these changes Sep 8, 2023

View reviewed changes

jkczyz approved these changes Sep 9, 2023

View reviewed changes

TheBlueMatt merged commit 448b191 into lightningdevkit:main Sep 10, 2023
11 of 14 checks passed

valentinewallace mentioned this pull request Sep 11, 2023

BOLT12 Offers Tracking Issue #1970

Open

60 tasks

valentinewallace mentioned this pull request Jan 10, 2024

Complete route blinding support #2812

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aggregate `BlindedPayInfo` for blinded routes #2514

Aggregate `BlindedPayInfo` for blinded routes #2514

valentinewallace commented Aug 22, 2023 •

edited

Loading

codecov-commenter commented Aug 23, 2023 •

edited

Loading

valentinewallace commented Aug 28, 2023

alecchendev left a comment

TheBlueMatt left a comment

valentinewallace commented Sep 6, 2023

TheBlueMatt commented Sep 6, 2023

Aggregate BlindedPayInfo for blinded routes #2514

Aggregate BlindedPayInfo for blinded routes #2514

Conversation

valentinewallace commented Aug 22, 2023 • edited Loading

codecov-commenter commented Aug 23, 2023 • edited Loading

Codecov Report

valentinewallace commented Aug 28, 2023

alecchendev left a comment

Choose a reason for hiding this comment

TheBlueMatt left a comment

Choose a reason for hiding this comment

valentinewallace commented Sep 6, 2023

TheBlueMatt commented Sep 6, 2023

Aggregate `BlindedPayInfo` for blinded routes #2514

Aggregate `BlindedPayInfo` for blinded routes #2514

valentinewallace commented Aug 22, 2023 •

edited

Loading

codecov-commenter commented Aug 23, 2023 •

edited

Loading