Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FundingLocked to ChannelReady. #1506

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented May 30, 2022

The funding_locked message was renamed to channel_ready as part of the ZeroConf spec PR.

This PR simply implements this spec change.

@tnull tnull force-pushed the 2022-05-rename-funding-locked branch from 6b96930 to 427dd8c Compare May 30, 2022 22:15
@tnull
Copy link
Contributor Author

tnull commented May 30, 2022

Squashed to fix check_commits.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #1506 (6b96930) into main (a534a5e) will decrease coverage by 0.03%.
The diff coverage is 87.84%.

❗ Current head 6b96930 differs from pull request most recent head be31f5c. Consider uploading reports for the commit be31f5c to get more accurate results

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   91.00%   90.97%   -0.04%     
==========================================
  Files          80       80              
  Lines       43396    43396              
  Branches    43396    43396              
==========================================
- Hits        39492    39478      -14     
- Misses       3904     3918      +14     
Impacted Files Coverage Δ
lightning-net-tokio/src/lib.rs 75.91% <0.00%> (-0.31%) ⬇️
lightning/src/ln/peer_handler.rs 57.06% <0.00%> (ø)
lightning/src/ln/shutdown_tests.rs 96.51% <ø> (ø)
lightning/src/ln/wire.rs 62.92% <0.00%> (ø)
lightning/src/routing/router.rs 92.45% <ø> (ø)
lightning/src/util/events.rs 41.66% <0.00%> (ø)
lightning/src/util/test_utils.rs 78.15% <0.00%> (ø)
lightning/src/ln/channelmanager.rs 84.36% <80.00%> (ø)
lightning/src/ln/channel.rs 88.59% <94.00%> (ø)
lightning-background-processor/src/lib.rs 94.37% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a534a5e...be31f5c. Read the comment docs.

@tnull tnull force-pushed the 2022-05-rename-funding-locked branch from 427dd8c to be31f5c Compare May 30, 2022 23:36
@tnull tnull force-pushed the 2022-05-rename-funding-locked branch from be31f5c to e98f68a Compare May 31, 2022 00:07
@TheBlueMatt TheBlueMatt merged commit 994fa07 into lightningdevkit:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants