Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event processing async-optional #1674

Closed
TheBlueMatt opened this issue Aug 17, 2022 · 0 comments · Fixed by #1787
Closed

Make event processing async-optional #1674

TheBlueMatt opened this issue Aug 17, 2022 · 0 comments · Fixed by #1787
Assignees
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Aug 17, 2022

Event processing must block the channel manager from persisting to avoid losing track of information. In a sync context this is easy - the background processor blocks on the event handler and won't go around the persistence loop. In an async context we need to add support for awaiting the event processing. Should be easy after #1657.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants