Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebalance: nits #250

Merged
merged 2 commits into from
Jun 15, 2021
Merged

rebalance: nits #250

merged 2 commits into from
Jun 15, 2021

Conversation

m-schmoock
Copy link
Member

No description provided.

@m-schmoock
Copy link
Member Author

m-schmoock commented Jun 15, 2021

@gallizoltan Nothing special I guess, just a second set of eyes as usual...

I wanted to start with the getroute_lowfee method but figured that it gets more complicated and we should use gossmap support and own routing for that i.e. by utilizing something like ElementsProject/lightning#4582 .
getroute does not have a good option to control fees.

Maybe we start with MPP or Gossmap custom routing next...

Copy link
Collaborator

@gallizoltan gallizoltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines -658 to +666
return {"message": "Rebalance stopped"}
return {"message": plugin.rebalanceall_msg}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! What an idea! This will be really informative!

@m-schmoock m-schmoock merged commit b516338 into lightningd:master Jun 15, 2021
@m-schmoock m-schmoock deleted the rebalance/nits branch June 15, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants